This repository has been archived by the owner on Feb 5, 2019. It is now read-only.
ARM: correct the relocation type for bl on WoA
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `IMAGE_REL_ARM_BRANCH20T` applies only to a `b.w` instruction. A thumb-2 `bl` should be relocated using a `IMAGE_REL_ARM_BRANCH24T`. Correct the relocation that we emit in such a case. Resolves PR38620! Based on the patch by Jordan Rhee! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@342109 91177308-0d34-0410-b5e6-96231b3b80d8
|
Thanks! |
This was referenced Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick /llvm-mirror/llvm#b8d7ba6811da32b73578d3512806483a8014e608 to fix object file generation for windows/arm
The
IMAGE_REL_ARM_BRANCH20Tapplies only to ab.winstruction. Athumb-2
blshould be relocated using aIMAGE_REL_ARM_BRANCH24T.Correct the relocation that we emit in such a case.
Resolves PR38620! Based on the patch by Jordan Rhee!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@342109 91177308-0d34-0410-b5e6-96231b3b80d8