Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest patch release increases MSRV #101

Closed
wezm opened this issue Jun 1, 2022 · 1 comment
Closed

Latest patch release increases MSRV #101

wezm opened this issue Jun 1, 2022 · 1 comment

Comments

@wezm
Copy link
Member

wezm commented Jun 1, 2022

The use of extended_key_value_attributes requires 1.54.0 or newer.

I don't see mention of a minimum supported Rust version in the README or Cargo.toml and note that CI tests on latest stable, beta, and nightly so perhaps this is not considered an issue but wanted to note the the latest patch release (1.1.8) breaks support for older Rust versions. The 1.1.6 release works at least as far back as 1.51.0.

Errors when compiling on 1.53.0:

https://gist.github.com/wezm/a46027bb12038bf396f00502eec112b7

alfiedotwtf added a commit to yeslogic/allsorts that referenced this issue Jun 7, 2022
wezm pushed a commit to yeslogic/allsorts that referenced this issue Jun 9, 2022
cliu2018 pushed a commit to yeslogic/allsorts that referenced this issue Jan 17, 2023
@joshtriplett
Copy link
Member

Thank you for catching this. (And sorry for the very long delay in responding. I've added a co-maintainer for this crate to help take better care of it. :) )

I had thought this crate documented an MSRV policy, but it indeed does not. I've added one, copied from the MSRV policy of the flate2 crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants