Use IFF_OACTIVE and IFF_RUNNING even on FreeBSD. Deprecate the DRV ones. #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
approved these changes
Nov 28, 2017
|
Thanks! Looks like CI is failing though? |
|
The failure is due to a "line longer than 80 characters" error in the style checker. |
mwanner
force-pushed
the
freebsd-drop-drv
branch
from
8a67ed1 to
13ce9f8
Compare
|
Overly long lines corrected, CI now happy. |
|
@bors: r+ |
|
📌 Commit 13ce9f8 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 29, 2017
Use IFF_OACTIVE and IFF_RUNNING even on FreeBSD. Deprecate the DRV ones. According to @asomers, libc should propagate the use of the portable constants `IFF_OACTIVE` and `IFF_RUNNING` for user-space applications, instead of `IFF_DRV_OACTIVE` and `IFF_DRV_RUNNING`. It least that's my understanding of [his comment](nix-rust/nix#667 (comment)) in nix-rust/nix#667.
|
☀️ Test successful - status-appveyor, status-travis |
ruuda
added a commit
to ruuda/thread-id
that referenced
this pull request
Dec 9, 2017
The libc crate started using the #[deprecated] attribute, which is not supported on Rust 1.8.0 stable, and results in a compile error. This change was presumably introduced in commit 13ce9f8 [1] as part of pull request 859 [2]. The solution is to put Cargo.lock under source control and freeze all dependency versions, to be more resilient to external changes. [1]: rust-lang/libc@13ce9f8 [2]: rust-lang/libc#859
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @asomers, libc should propagate the use of the portable constants
IFF_OACTIVEandIFF_RUNNINGfor user-space applications, instead ofIFF_DRV_OACTIVEandIFF_DRV_RUNNING. It least that's my understanding of his comment in nix-rust/nix#667.