Add additional interface flags (IFF_) #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is failing? |
|
OK. At this point I don't understand why the build is failing, some help would be appreciated. |
|
it is failing because the C part (of the test) doesn't found the it could be just a missing C header in the test program. If so, you need to update The test will use them to check the accuracy of the Rust definition. |
|
Thanks @semarie. Upon adding How can I resolve this? |
|
it is a C (and Linux) problem. Headers had to be included in the right order. As I don't use Linux, I couldn't tell. |
|
Add that header to the bottom of build.rs. I added a separate test binary for dealing with things like this which is specified towards the bottom of the file. So set the main test binary to ignore these constants and then only test them in the second binary. Because the second binary doesn't have so many headers you likely won't have a problem. You can see this is done for other constants and can follow a similar pattern. |
|
@Susurrus Thank you! I'll do that tomorrow. Much appreciated. |
Also remove unneeded platform gating
NoraCodes
force-pushed
the
add_linux_iff_constants
branch
from
96212be to
121795e
Compare
|
Progress! It's still failing, but only on |
NoraCodes
force-pushed
the
add_linux_iff_constants
branch
from
4d0b775 to
6f170ef
Compare
|
All green! |
|
@bors: r+ Thanks! |
|
📌 Commit 6f170ef has been approved by |
bors
added a commit
that referenced
this pull request
Sep 12, 2017
Add additional interface flags (IFF_) Adds the three missing IFF_ constants (IFF_LOWER_UP, IFF_DORMANT, and IFF_ECHO) per nix-rust/nix#764
|
☀️ Test successful - status-appveyor, status-travis |
Susurrus
reviewed
Sep 13, 2017
| @@ -662,6 +665,10 @@ fn main() { | |||
| } else { | |||
| cfg.header("linux/fcntl.h"); | |||
| } | |||
| if !musl { | |||
There was a problem hiding this comment.
This should not have been necessary because these constants aren't tested in this binary. Only your changes to the "main" test binary should have been necessary. Did you try this PR without this change first and only added it once you saw tests failing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the three missing IFF_ constants (IFF_LOWER_UP, IFF_DORMANT, and IFF_ECHO) per nix-rust/nix#764