change type of INADDR constants to in_addr_t #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ Nah looks fine to me! |
|
📌 Commit ef1cb07 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 25, 2017
change type of INADDR constants to in_addr_t These should be `in_addr_t` (u32) instead of `c_int` This is a breaking change but it is just breaking newlib platforms for now. @alexcrichton Do you prefer that I split the definition in submodules, to keep `c_int` in newlib and update the others ?
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be
in_addr_t(u32) instead ofc_intThis is a breaking change but it is just breaking newlib platforms for now.
@alexcrichton Do you prefer that I split the definition in submodules, to keep
c_intin newlib and update the others ?