Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uclibc] add more structs to x86_64 #626

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

humenda
Copy link
Contributor

@humenda humenda commented Jun 24, 2017

This adds more structs to the uclibc/x86_64 port.

This adds more structs to the uclibc/x86_64 port.
@Susurrus
Copy link
Contributor

Removing the in_addr and in6_addr structs is a breaking change and will prevent this PR from being merged. I suggest you remove those changes, either fixing those structs or leaving a comment there like you did stating they may be incorrect, in order to get this PR merged in a timely fashion.

@alexcrichton
Copy link
Member

This is actually a tier 3 platform so breakage is ok (nothing is automatically verified here). @humenda despite this though was there a reason to remove those structs?

@humenda
Copy link
Contributor Author

humenda commented Jun 25, 2017 via email

@alexcrichton
Copy link
Member

Ok, I think you're the main user of uclibc on x86_64 for now, so sounds good!

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 25, 2017

📌 Commit c7a7cd8 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jun 25, 2017

⌛ Testing commit c7a7cd8 with merge dc391d6...

bors added a commit that referenced this pull request Jun 25, 2017
[uclibc] add more structs to x86_64

This adds more structs to the uclibc/x86_64 port.
@bors
Copy link
Contributor

bors commented Jun 25, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jun 26, 2017 via email

@bors
Copy link
Contributor

bors commented Jun 26, 2017

⌛ Testing commit c7a7cd8 with merge 457f02a...

bors added a commit that referenced this pull request Jun 26, 2017
[uclibc] add more structs to x86_64

This adds more structs to the uclibc/x86_64 port.
@bors bors mentioned this pull request Jun 26, 2017
@bors
Copy link
Contributor

bors commented Jun 26, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jun 26, 2017 via email

@bors
Copy link
Contributor

bors commented Jun 26, 2017

⌛ Testing commit c7a7cd8 with merge 46f71e2...

bors added a commit that referenced this pull request Jun 26, 2017
[uclibc] add more structs to x86_64

This adds more structs to the uclibc/x86_64 port.
@bors
Copy link
Contributor

bors commented Jun 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 46f71e2 to master...

@bors bors merged commit c7a7cd8 into rust-lang:master Jun 26, 2017
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
…g#626)

This commit implements automatic verification of implement ARM/AArch64
intrinsics. Or it's at least a start! This downloads a snapshot of ARM's
[online documentation][docs] and implements necessary logic to parse
that and use it to verify all the intrinsics. Almost everything
checked out A-OK but a few minor tweaks were needed to the neon
intrinsics and the crc ones needed some renaming.

[docs]: https://developer.arm.com/technologies/neon/intrinsics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants