Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify FIXMEs - 5.2 #4237

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Classify FIXMEs - 5.2 #4237

merged 1 commit into from
Feb 5, 2025

Conversation

lvllvl
Copy link
Contributor

@lvllvl lvllvl commented Jan 7, 2025

Description

Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
    • Not applicable
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
    • Not applicable

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 10, 2025
@lvllvl lvllvl force-pushed the 4117-part-5-2 branch 2 times, most recently from f34b049 to 8cbc185 Compare January 13, 2025 01:07
@lvllvl lvllvl requested a review from tgross35 January 13, 2025 01:26
@lvllvl
Copy link
Contributor Author

lvllvl commented Jan 28, 2025

hi @tgross35 , this PR is ready for another review. Please let me know if you'd like any other changes.
Thanks!

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, CI has been stuck for a little while. Thanks!

@tgross35 tgross35 enabled auto-merge February 5, 2025 11:06
@tgross35 tgross35 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into rust-lang:main with commit d1c4062 Feb 5, 2025
44 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Feb 18, 2025
(backport <rust-lang#4237>)
(cherry picked from commit 6c6674e)
@tgross35 tgross35 mentioned this pull request Feb 18, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants