Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to windows-sys crate #3915

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Link to windows-sys crate #3915

merged 1 commit into from
Sep 25, 2024

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Sep 11, 2024 •
edited
Loading

WinAPI provides low level libc-like functions but for Windows. One may expect to find it here, so provide the links.

windows-sys is provided by Microsoft. Official, looks good.

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 reviewed Sep 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@tgross35
Copy link
Contributor

tgross35 commented Sep 24, 2024 •
edited
Loading

I think this is a good idea, but there isn't any reason to link an unmaintained crate. Just remove the winapi crate mention and one nit above, then LGTM.

@rustbot label +stable-nominated
@rustbot author

@rustbot rustbot added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-author and removed S-waiting-on-review labels Sep 24, 2024
@stepancheg
Link windows-sys crate
05a017d 
WinAPI provides low level libc-like functions but for Windows.
One may expect to find it here, so provide the links.

`windows-sys` is provided by Microsoft. Official, looks good.
@stepancheg stepancheg changed the title Link to winapi and windows-sys crates Link to windows-sys crate Sep 24, 2024
tgross35
tgross35 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into rust-lang:main with commit 433d019 Sep 25, 2024
41 checks passed
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@stepancheg @tgross35
Link windows-sys crate (rust-lang#3915)
b862acf 
WinAPI provides low level libc-like functions but for Windows.
One may expect to find it here, so provide the links.

`windows-sys` is provided by Microsoft. Official, looks good.

(backport <rust-lang#3915>)
(cherry picked from commit 433d019)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@stepancheg @tgross35
Link windows-sys crate (rust-lang#3915)
5951de5 
WinAPI provides low level libc-like functions but for Windows.
One may expect to find it here, so provide the links.

`windows-sys` is provided by Microsoft. Official, looks good.

(backport <rust-lang#3915>)
(cherry picked from commit 433d019)
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-author stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancheg @rustbot @tgross35 @JohnTitor