Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.2] TEEOS: Fix octal notation for O_* constants #3841

Merged
merged 1 commit into from
Aug 17, 2024
Merged

[0.2] TEEOS: Fix octal notation for O_* constants #3841

merged 1 commit into from
Aug 17, 2024

Conversation

nathaniel-bennett
Copy link
Contributor

Backport of #3840 for libc 0.2

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

tgross35 commented Aug 16, 2024 •
edited
Loading

Could you do the cherry-pick with -x so the commits wind up linked? In lieu of us being able to merge between the branches.

There are some directions at https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md#v10-roadmap

@nathaniel-bennett
Copy link
Contributor Author

Cherry-picked now 👍

tgross35
tgross35 approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Aug 17, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 9b1ec25 Aug 17, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathaniel-bennett @rustbot @tgross35