Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc 1.0] Put a big warning to Linux's dirent docs #3650

Closed
wants to merge 1 commit into from

Conversation

safinaskar
Copy link

This fixes my bug #2669 .

We cannot change type for d_name field, because this will break tests. So the only thing we can do is to document dirent behavior.

The question remains what are exact rules for dealing with dirent, but this is left to Rust specification

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@safinaskar
Copy link
Author

CI is failing, but it seems this is not because of my patch

@JohnTitor
Copy link
Member

We should resolve the issue instead of emitting warnings on 1.0 as we can introduce breaking changes there.

@JohnTitor JohnTitor closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants