Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uclibc: fix semver files, add misc symbols #2403

Merged
merged 8 commits into from
Sep 24, 2021
Merged

Conversation

skrap
Copy link
Contributor

@skrap skrap commented Sep 17, 2021

This commit gets uclibc support working again, and fixes the semver lists to segregate gnu- and musl- specific symbols to those libc variants.

There is a separate PR against rust itself to add armv7-unknown-linux-uclibceabihf as a tier 3 platform, and this commit is in support of that effort. Until that's done, we should not use the CI for that platform, but I'm including the CI file here in anticipation of turning it on in the not-too-distant future.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

libc-test/build.rs Outdated Show resolved Hide resolved
@Amanieu
Copy link
Member

Amanieu commented Sep 22, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 22, 2021

📌 Commit 6a12326 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Sep 22, 2021

⌛ Testing commit 6a12326 with merge 432151f...

bors added a commit that referenced this pull request Sep 22, 2021
uclibc: fix semver files, add misc symbols

This commit gets uclibc support working again, and fixes the semver lists to segregate gnu- and musl- specific symbols to those libc variants.

There is a [separate PR](rust-lang/rust#88952) against rust itself to add armv7-unknown-linux-uclibceabihf as a tier 3 platform, and this commit is in support of that effort.  Until that's done, we should not use the CI for that platform, but I'm including the CI file here in anticipation of turning it on in the not-too-distant future.
@bors
Copy link
Contributor

bors commented Sep 22, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Sep 22, 2021

@bors retry

@bors
Copy link
Contributor

bors commented Sep 22, 2021

⌛ Testing commit 6a12326 with merge 54c5830...

bors added a commit that referenced this pull request Sep 22, 2021
uclibc: fix semver files, add misc symbols

This commit gets uclibc support working again, and fixes the semver lists to segregate gnu- and musl- specific symbols to those libc variants.

There is a [separate PR](rust-lang/rust#88952) against rust itself to add armv7-unknown-linux-uclibceabihf as a tier 3 platform, and this commit is in support of that effort.  Until that's done, we should not use the CI for that platform, but I'm including the CI file here in anticipation of turning it on in the not-too-distant future.
@bors
Copy link
Contributor

bors commented Sep 22, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Sep 22, 2021

A lot of tests failing with "constant is never used". Are you sure these are exported publicly all the way to the crate root?

@skrap
Copy link
Contributor Author

skrap commented Sep 23, 2021

A lot of tests failing with "constant is never used". Are you sure these are exported publicly all the way to the crate root?

Ah, that's for the mips build, which is a target I did not test. I'll fix. (There's a few uclibc targets which I don't really know how to build for, but I should be able to figure it out.)

@Amanieu
Copy link
Member

Amanieu commented Sep 24, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2021

📌 Commit 7a64fe9 has been approved by Amanieu

bors added a commit that referenced this pull request Sep 24, 2021
uclibc: fix semver files, add misc symbols

This commit gets uclibc support working again, and fixes the semver lists to segregate gnu- and musl- specific symbols to those libc variants.

There is a [separate PR](rust-lang/rust#88952) against rust itself to add armv7-unknown-linux-uclibceabihf as a tier 3 platform, and this commit is in support of that effort.  Until that's done, we should not use the CI for that platform, but I'm including the CI file here in anticipation of turning it on in the not-too-distant future.
@bors
Copy link
Contributor

bors commented Sep 24, 2021

⌛ Testing commit 7a64fe9 with merge ef9efd1...

@bors
Copy link
Contributor

bors commented Sep 24, 2021

💔 Test failed - checks-actions

@skrap
Copy link
Contributor Author

skrap commented Sep 24, 2021

Hm, the breakage is now in the x86_64-unknown-l4re-uclibc target. I don't know how to build this tier 3 target (I'm not familiar with the L4RE project), so I may just take my best guess as to the fixes and push.

@Amanieu
Copy link
Member

Amanieu commented Sep 24, 2021

Let's give it a try!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2021

📌 Commit 95656b9 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Sep 24, 2021

⌛ Testing commit 95656b9 with merge 372a8c6...

@bors
Copy link
Contributor

bors commented Sep 24, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 372a8c6 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants