Fix statfs for DragonFlyBSD #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct was missing several padded areas, causing all values to be wrong.
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Amanieu
reviewed
Aug 25, 2021
| pub f_syncwrites: ::c_long, | ||
| pub f_asyncwrites: ::c_long, | ||
| pub f_fstypename: [::c_char; 16], | ||
| pub f_mntonname: [::c_char; 90], | ||
| pub f_mntonname: [::c_char; 80], |
There was a problem hiding this comment.
Do we have constants that we could use here?
There was a problem hiding this comment.
The C source defines MFSNAMELEN and MNAMELEN, but I don't see any equivalents in rust's libc. I can add these as constants if you'd prefer.
There was a problem hiding this comment.
You're right, none of the other targets use a constant. I guess it's fine as it is.
|
@bors r+ |
|
📌 Commit f09c62c has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statfs struct was missing several padding areas and used incorrect array lengths, causing all values to be incorrect.
DragonFlyBSD's own documentation seems to be wrong here, which is likely how this ended up being incorrect in the first place.
Source: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/27ea30e396c40d8feb44d76002b79153e96ecf8f/sys/sys/mount.h#L95
Documentation: https://man.dragonflybsd.org/?command=statfs§ion=2