Fix termios constants on redox #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 249e213 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
bors bot
added a commit
to nix-rust/nix
that referenced
this pull request
Aug 9, 2021
1483: Remove some actually unsupported termios iflags on redox r=asomers a=coolreader18 Related to rust-lang/libc#2327 Co-authored-by: Noah <[email protected]>
|
Would you be able to cut a new release with this? I'm excited about finally getting termios stuff working on redox, and this was a really prevalent issue on the userspace side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The termios constants on redox were just completely wrong, so I got the correct values from https://gitlab.redox-os.org/redox-os/relibc/-/blob/master/src/header/termios/redox.rs