-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rust union types #2056
base: main
Are you sure you want to change the base?
Use Rust union types #2056
Conversation
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Also I had to ignore |
Unfortunately I believe this is a breaking change, which means we can't actually do this until we bump the crate version to 1.0. cc @JohnTitor |
I'm aware that it is a breaking change and that's not a problem for me to wait until a new major version for this to be merged. |
☔ The latest upstream changes (presumably #1975) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm unsure how to find out what's wrong with sigval on emscripten... |
Btw, I noted (when I originally opened this PR) that the following fields may also be wroth considering turning into unions:
|
I also don't know. I'll mark this as review as a reminder that I need to take a look at this. @rustbot review
Feel free to submit another PR! |
This needs another rebase, feel free to just leave Regarding traits: don't add For @rustbot author |
For #1020
Replace some types with unions now that rustc supports them.
I also found
sigevent.sigev_notify_thread_id
,siginfo_t.__data
andsigaction.sa_sigaction
that I think should be unions, but I wasn't sure.