freebsdlike: add SCM_CREDS, struct sockcred #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
|
This change looks good, but you should also define that constant for NetBSD (0x4), OpenBSD (0x2), and OSX (0x3). |
|
It's already defined for Apple and NetBSD — but it's (correctly) not 0x4 on the latter: |
|
And it hasn't been available in OpenBSD since 2012 (I wonder what these "newer APIs" are lol) |
Ahh, good catch. It looks like NetBSD changed it 4 years ago, and wisely added a backwards-compatibility version: NetBSD/src@8e79650 . I was looking at NetBSD 6 source. |
It is present on both FreeBSD and DragonFly
Like on NetBSD, but without a pid field in the struct.
valpackett
force-pushed
the
freebsd-creds
branch
from
d031538 to
d8764e8
Compare
valpackett
changed the title
bors bot
added a commit
to nix-rust/nix
that referenced
this pull request
May 2, 2020
1216: Add UnixCredentials support on FreeBSD/DragonFly r=asomers a=myfreeweb This allows working with `SCM_CREDS` messages, which are like `SCM_CREDENTIALS` on Linux, but slightly different (always overwritten by the kernel, contain a bit more info — euid and groups). With this PR, it is possible to write portable code that would use the appropriate message for the platform, but one remaining quirk is that `PassCred` thing still has to be present and `cfg`'d to Linux. Adding the `SCM_CREDS` constant to libc: rust-lang/libc#1740 Co-authored-by: Greg V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCM_CREDSis present on both FreeBSD and DragonFly, is used for sendingstruct cmsgcredcontrol messagesstruct sockcredis present on FreeBSD, is used withLOCAL_CREDSsocket option