Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential incorrect type for ptrace requests with musl #744

Closed
xd009642 opened this issue Aug 27, 2017 · 3 comments
Closed

Potential incorrect type for ptrace requests with musl #744

xd009642 opened this issue Aug 27, 2017 · 3 comments

Comments

@xd009642
Copy link
Contributor

For some reason normal ptrace requests i.e. PTRACE_TRACEME are c_int whereas the ptrace requests related to program registers (i.e. PTRACE_GETREGS) are unsigned integers musl mod.rs. Now as all these values are used as the request argument to fn ptrace surely the sign should be consistent?

musl is also the only libc environment which has the difference in signedness which also doesn't seem to be mimicking musl itself ptrace.h musl
@xd009642 xd009642 mentioned this issue Aug 27, 2017
Closed
@alexcrichton
Copy link
Member

While technically a breaking change to fix this, my guess is that it's fine to fix in a point release as it's unlikely to break anyone.

@xd009642
Copy link
Contributor Author

I'd only expect it to make a cast unnecessary for some users. I'll submit a pull request later today then unless it's already being covered 👍

@xd009642 xd009642 mentioned this issue Aug 27, 2017
Merged
bors added a commit that referenced this issue Aug 27, 2017
@bors
Auto merge of #745 - xd009642:master, r=alexcrichton
1c1413e 
Updated types of PTRACE requests for musl to be consistent.

For some reason the type of ptrace request constants in musl change for the register based requests. As they are used in the same way and this doesn't mimic musl this has been changed for consistency and ease of use.

First raised in issue #744
@xd009642
Copy link
Contributor Author

Closing this issue as #745 is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @xd009642