You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some reason it's ignored in build.rs, but my /usr/include/unistd.h on Mac OS X 10.11.6 doesn't have it. It's actually nowhere in /usr/include/. Using this results in a linking error, so I'd suggest it be removed on those platforms even if it's technically a breaking change (as nobody can possibly be using it on those platforms).
I can file a PR to remove it, but what to do about build.rs, anything? Should I change it to be if mac for fexecve to make sure it never creeps back in accidentally?
The text was updated successfully, but these errors were encountered:
Seems fine to me yeah to remove! IIRC these are ignored b/c the exec-family of functions are really hard to verify (the signatures in C are tough for ctest to generate to match)
Remove fexecvpe from Haiku and MacOS/IOS where it's not implemented
I was going to remove the skip-check from `build.rs` to see if we might be able to enable the function check on at least some platforms, but I'll assume it doesn't work on any as has been suggested.
Closes#732.
For some reason it's ignored in build.rs, but my
/usr/include/unistd.h
on Mac OS X 10.11.6 doesn't have it. It's actually nowhere in/usr/include/
. Using this results in a linking error, so I'd suggest it be removed on those platforms even if it's technically a breaking change (as nobody can possibly be using it on those platforms).I can file a PR to remove it, but what to do about
build.rs
, anything? Should I change it to beif mac
forfexecve
to make sure it never creeps back in accidentally?The text was updated successfully, but these errors were encountered: