Resize with a more conservative amount of space after deletions #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a better solution would be to change the else clause to self.resize(usize::max(new_size, full_capacity + 1), hasher, fallability)This ensures that we always increase the table size if we are resizing. Also the condition should probably be changed from |
…deletions.
Otherwise we can force a rehash for each insert and removal if we're right under the size limit.
Benchmark with SIZE=895, just under a rehash limit.
name oops ns/iter okthen ns/iter diff ns/iter diff % speedup
insert_erase_std_serial 9,875,585 60,696 -9,814,889 -99.39% x 162.71
Fixes rust-lang#85
|
@bors r+ |
|
📌 Commit afc20d7 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 6, 2019
Resize with a more conservative amount of space after deletions
Otherwise we can force a rehash for each insert and removal if we're right under the size limit.
Benchmark with SIZE=895, just under a rehash limit.
name oops ns/iter okthen ns/iter diff ns/iter diff % speedup
insert_erase_std_serial 9,875,585 60,696 -9,814,889 -99.39% x 162.71
Fixes #85
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we can force a rehash for each insert and removal if we're right under the size limit.
Benchmark with SIZE=895, just under a rehash limit.
name oops ns/iter okthen ns/iter diff ns/iter diff % speedup
insert_erase_std_serial 9,875,585 60,696 -9,814,889 -99.39% x 162.71
Fixes #85