Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden tests for symlink #127

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Harden tests for symlink #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion tests/glob-std.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,19 @@ fn main() {
}
}

fn mk_symlink_file(original: &str, link: &str) {
#[cfg(unix)]
{
use std::os::unix::fs::symlink;
symlink(original, link).unwrap();
}
#[cfg(windows)]
{
use std::os::windows::fs::symlink_file;
symlink_file(original, link).unwrap();
}
}

fn glob_vec(pattern: &str) -> Vec<PathBuf> {
glob(pattern).unwrap().map(|r| r.unwrap()).collect()
}
Expand All @@ -48,6 +61,10 @@ fn main() {
mk_file("bbb", true);
mk_file("bbb/specials", true);
mk_file("bbb/specials/!", false);
// a valid symlink
mk_symlink_file("aaa/apple", "aaa/green_apple");
// a broken symlink
mk_symlink_file("aaa/setsuna", "aaa/kazusa");

// windows does not allow `*` or `?` characters to exist in filenames
if env::consts::FAMILY != "windows" {
Expand Down Expand Up @@ -223,15 +240,19 @@ fn main() {
glob_vec("aaa/*"),
vec!(
PathBuf::from("aaa/apple"),
PathBuf::from("aaa/green_apple"),
PathBuf::from("aaa/kazusa"),
PathBuf::from("aaa/orange"),
PathBuf::from("aaa/tomato")
PathBuf::from("aaa/tomato"),
)
);

assert_eq!(
glob_vec("aaa/*a*"),
vec!(
PathBuf::from("aaa/apple"),
PathBuf::from("aaa/green_apple"),
PathBuf::from("aaa/kazusa"),
PathBuf::from("aaa/orange"),
PathBuf::from("aaa/tomato")
)
Expand Down Expand Up @@ -262,6 +283,9 @@ fn main() {

assert_eq!(glob_vec("aaa/tomato/tomato.txt/"), Vec::<PathBuf>::new());

// Ensure to find a broken symlink.
assert_eq!(glob_vec("aaa/kazusa"), vec!(PathBuf::from("aaa/kazusa")));

assert_eq!(glob_vec("aa[a]"), vec!(PathBuf::from("aaa")));
assert_eq!(glob_vec("aa[abc]"), vec!(PathBuf::from("aaa")));
assert_eq!(glob_vec("a[bca]a"), vec!(PathBuf::from("aaa")));
Expand Down