Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git2-hyper backend #685

Closed
wants to merge 4 commits into from
Closed

Conversation

henry40408
Copy link

First step of #623. The crate introduces rustls and hyper and tokio as async runtime.

@mainrs
Copy link

mainrs commented Mar 21, 2021

Wouldn't it be better to have two new features? One that uses hyper with native tls and one that uses hyper with rustls?

Edit: Ok, I think this PR is just about bringing the backend into the workspace. Is the plan to do a follow-up PR with all the other needed changes?

git2-hyper/src/lib.rs Outdated Show resolved Hide resolved
git2-hyper/src/lib.rs Outdated Show resolved Hide resolved
@alexcrichton
Copy link
Member

Thanks for the PR! This seems fine to me but I personally don't really know much about all the pieces involved here. For example I wouldn't be able to help out with bug reports, fix CI, etc. For those reasons could something like this live external to this repository? I'd be fine linking to a git2-hyper repository of course!

@henry40408 henry40408 closed this Oct 27, 2021
@henry40408 henry40408 deleted the feature/hyper branch October 27, 2021 13:08
@mitchmindtree
Copy link

@henry40408 exciting stuff - any follow-up on this? Quite interested for a downstream project that's looking to move away from openssl.

@henry40408
Copy link
Author

hi @mitchmindtree, I have opened a repository and prepare to publish on https://crates.io. stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants