Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please make a release with libgit2 1.6.1 #936

Closed
0-wiz-0 opened this issue Feb 28, 2023 · 5 comments
Closed

please make a release with libgit2 1.6.1 #936

0-wiz-0 opened this issue Feb 28, 2023 · 5 comments

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Feb 28, 2023

libgit2 1.6.1 has been released, which (among other fixes) contains a fix for NetBSD which particularly affects git2-rs when no system libgit2 is used (where currently the build is broken due to a conflict with system headers).
Can you please make a new release using libgit2 1.6.1 so this fix be used in other projects? Thank you.
@0323pin
Copy link

0323pin commented Feb 28, 2023

Yes, please. This would save us a lot of issues.

@extrawurst
Copy link
Contributor

there is a draft PR already: #935

@0323pin
Copy link

0323pin commented Feb 28, 2023

Good, let's wait for it.
Right now can't update, e.g. onefetch

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Mar 2, 2023
@0-wiz-0
libgit2: downgrade to 1.5.1
0f1cdf8 
keep the pkg-config file fix, bump PKGREVISION for that

Wait for libgit2/libgit2#6519 and
rust-lang/git2-rs#936 before upgrading.
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Mar 30, 2023
@0-wiz-0
doc/TODO: + libgit2-1.6.3 [wait for rust-lang/git2-rs#936].
e7007a8
@sshine
Copy link

sshine commented Apr 18, 2023

Since #935 is merged, perhaps close this issue?

@ehuss
Copy link
Contributor

ehuss commented Apr 18, 2023

Indeed, thanks!

@ehuss ehuss closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ehuss @sshine @extrawurst @0-wiz-0 @0323pin