Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2-sys 0.8.2 binds API from libgit2 master, not 0.28.2 #458

Closed
jbeich opened this issue Aug 17, 2019 · 1 comment
Closed

libgit2-sys 0.8.2 binds API from libgit2 master, not 0.28.2 #458

jbeich opened this issue Aug 17, 2019 · 1 comment

Comments

@jbeich
Copy link

jbeich commented Aug 17, 2019 •
edited
Loading

Regressed by #440

git_url_resolve_cb is not part of any libgit2 release from maint/v0.28 branch. If built with LIBGIT2_SYS_USE_PKG_CONFIG runtime fails e.g., rust-lang/rust#63476. Can you restore 0.28 API compatibility for libgit2-sys 0.8.3 and bump required version for libgit2-sys 0.9.0?

git2-rs/libgit2-sys/build.rs

Line 15 in 4c9480a

if let Ok(lib) = cfg.atleast_version("0.28.0").probe("libgit2") {

@alexcrichton
Copy link
Member

The pkg-config scripts are off-by-default because there's no strong guarantee made about the libgit2 bundled version, it's opt-in and susceptible to breakage.

@smaeul smaeul mentioned this issue Nov 8, 2019
Closed
ColinFinck added a commit to ColinFinck/meta-rust that referenced this issue Oct 6, 2020
@ColinFinck
Disable LIBGIT2_SYS_USE_PKG_CONFIG due to incompatibility with 0.28.x
26d7a34 
libgit2 0.28.x is shipped by latest Yocto Dunfell.
According to rust-lang/git2-rs#458 (comment), there are no compatibility guarantees between libgit2-sys and arbitrary system libgit2 versions, so better keep this turned off.

Fixes "invalid version 3 on git_proxy_options" during build.

Further references:
* rust-lang/git2-rs#458
* https://bugs.gentoo.org/707746#c1
ColinFinck added a commit to ColinFinck/meta-rust that referenced this issue Oct 6, 2020
@ColinFinck
Disable LIBGIT2_SYS_USE_PKG_CONFIG due to incompatibility with 0.28.x
8a44bae 
libgit2 0.28.x is shipped by latest Yocto Dunfell.
According to rust-lang/git2-rs#458 (comment), there are no compatibility guarantees between libgit2-sys and arbitrary system libgit2 versions, so better keep this turned off.

Fixes "invalid version 3 on git_proxy_options" during build.

Further references:
* rust-lang/git2-rs#458
* https://bugs.gentoo.org/707746#c1
@ColinFinck ColinFinck mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @jbeich