add #[must_use] new_call function to show warning #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Mar 21, 2024
examples/brainfuck/src/main.rs
Outdated
| @@ -107,6 +107,7 @@ fn codegen<'a, 'ctx>(ops: &[Op], context: &'a gccjit::Context<'ctx>) -> bool { | |||
| let mut current_block = brainf_main.new_block("entry_block"); | |||
| // now we have to zero out the giant buffer we just allocated on the stack. | |||
| let zero_access = context.new_array_access(None, array.to_rvalue(), context.new_rvalue_zero(int_ty)); | |||
| // a call to context.new_call will give us warning | |||
There was a problem hiding this comment.
I would only keep this comment, so please remove the others.
And please edit the comment to something like this:
Suggested change
| // a call to context.new_call will give us warning | |
| // A function call that is done for its side effects must be sent to add_eval. |
|
@antoyo these changes has been push as requested |
antoyo
reviewed
Mar 21, 2024
examples/brainfuck/src/main.rs
Outdated
| @@ -172,11 +173,13 @@ fn codegen<'a, 'ctx>(ops: &[Op], context: &'a gccjit::Context<'ctx>) -> bool { | |||
| } | |||
| Op::Input => { | |||
| let access = context.new_array_access(None, array.to_rvalue(), memory_ptr.to_rvalue()); | |||
|
|
|||
There was a problem hiding this comment.
Please remove this new line and the others below.
|
@antoyo new line remove |
|
oh, really, |
|
@antoyo space remove |
|
Thanks for your contribution. |
|
@mubarak23: Also, please do not ping me as I get a notification from GitHub so I already know you pushed your changes :) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.