Remove deprecated functionality #731
Conversation
src/task_impl/mod.rs
Outdated
| @@ -58,7 +57,6 @@ fn with<F: FnOnce(&BorrowedTask) -> R, R>(f: F) -> R { | |||
| pub struct Task { | |||
| id: usize, | |||
There was a problem hiding this comment.
Weird I thought this was deprecated but we may still be using it somewhere? Can always figure that out later of course.
There was a problem hiding this comment.
We never deprecated the actual id but all usage of it has been deprecated.
The id should be removed in 0.2.
There was a problem hiding this comment.
Isn't id still used in calls to with_notify, so that it will be passed down into the inner call to notify?
There was a problem hiding this comment.
It is indeed! That's, confusingly, a different id though, which indeed can't be removed unless we remove the ids from the Notify trait.
| use super::core; | ||
| use super::{BorrowedTask, NotifyHandle, Spawn, spawn, Notify, UnsafeNotify}; | ||
| pub use super::core::{BorrowedUnpark, TaskUnpark}; |
There was a problem hiding this comment.
Now that there's no need for unpark events this can (in the future of course if you'd prefer) be cleaned up a lot and not have this sd/core business. These types can move from the core module directly into the parent module here to directly make up Task and remove a few layers of indirection in the meantime.
Cargo.toml
Outdated
| @@ -22,8 +22,7 @@ appveyor = { repository = "alexcrichton/futures-rs" } | |||
|
|
|||
| [features] | |||
| use_std = [] | |||
There was a problem hiding this comment.
While we're at it I think the conventional name for this today is just std, so we could change that here too
@alexcrichton