Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expected size of select_on_non_unpin_size #2119

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Update expected size of select_on_non_unpin_size #2119

merged 2 commits into from
Apr 15, 2020

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Apr 7, 2020

Probably comes from rust-lang/rust#69837

@Nemo157 Nemo157 mentioned this pull request Apr 7, 2020
Closed
@Nemo157
Copy link
Member Author

Nemo157 commented Apr 7, 2020 •
edited
Loading

Doc build failure is likely rust-lang/rust#70814

@Nemo157 Nemo157 mentioned this pull request Apr 8, 2020
Merged
1 task
@taiki-e
Copy link
Member

taiki-e commented Apr 11, 2020

Doc build failure is likely rust-lang/rust#70814

I would like to suggest adding -Aunused_braces to RUSTDOCFLAGS until it is fixed.

futures-rs/.travis.yml

Line 148 in 2f8943d

- RUSTDOCFLAGS=-Dwarnings cargo doc --workspace --no-deps --all-features

@Nemo157 Nemo157 merged commit 6ba6716 into master Apr 15, 2020
@Nemo157 Nemo157 deleted the Nemo157/gen-size-change branch April 15, 2020 08:38
exrook pushed a commit to exrook/futures-rs that referenced this pull request Apr 5, 2021
@Nemo157
Merge pull request rust-lang#2119 from rust-lang/Nemo157/gen-size-change
44e1739 
Update expected size of `select_on_non_unpin_size`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @taiki-e