Use our own either type #1527
Merged
Use our own either type #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
reviewed
Apr 16, 2019
cramertj
reviewed
Apr 16, 2019
|
works for me, modulo the removal of doc examples and the introduction of |
taiki-e
force-pushed
the
util-either
branch
2 times, most recently
from
f60b960 to
dce775b
Compare
cramertj
reviewed
Apr 18, 2019
futures-util/src/future/mod.rs
Outdated
| /// } | ||
| /// ``` | ||
| fn select<B>(self, other: B) -> Select<Self, B::Future> | ||
| where B: IntoFuture, Self: Sized | ||
| fn select<B>(self, other: B) -> Select<Self, B> |
There was a problem hiding this comment.
We just changed the .join methods into free functions-- seems like that would make sense for select as well?
There was a problem hiding this comment.
Thanks for pointing that out, it makes sense. And I remembered that I forgot to write PR for changing StreamExt::select to a function 😅 .
|
Nice! thanks for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1152