Renamed corrupt test gzip file #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jose-pr
added a commit
to jose-pr/flate2-rs
that referenced
this pull request
Jul 29, 2021
Fixes what rust-lang#277 tried to fixed, changing the name alone wont fix the problem as the renamed file still contains the GZ magic number and will still be detected by a file scanner as a corrupt GZ file. Used the following to generate the hex file. ``` fn bin_to_hex(bin_reader: impl Read, hex_writer: impl Write) { let bin_reader = BufReader::new( bin_reader); let mut hex_writer = BufWriter::new( hex_writer); for byte in bin_reader.bytes() { let byte = byte.unwrap(); write!(hex_writer, "{:X} ", byte).unwrap(); } hex_writer.flush().unwrap(); } ```
jose-pr
added a commit
to jose-pr/flate2-rs
that referenced
this pull request
Jul 30, 2021
Fixes what rust-lang#277 tried to fixed, changing the name alone wont fix the problem as the renamed file still contains the GZ magic number and will still be detected by a file scanner as a corrupt GZ file. Used the following to generate the hex file. ``` fn bin_to_hex(bin_reader: impl Read, hex_writer: impl Write) { let bin_reader = BufReader::new( bin_reader); let mut hex_writer = BufWriter::new( hex_writer); for byte in bin_reader.bytes() { let byte = byte.unwrap(); write!(hex_writer, "{:X} ", byte).unwrap(); } hex_writer.flush().unwrap(); } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corrupt gzip file used in the tests prevents some systems from mirroring this crate because the system's antivirus software rejects corrupt files that it cannot scan.