Support cloudfire optimized version of zlib as a backend #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurprs
force-pushed
the
cloudflare_zlib
branch
from
21869ce
to
6609b58
Compare
|
Nice! Mind adding this to CI as well to get tested? |
arthurprs
force-pushed
the
cloudflare_zlib
branch
from
6609b58
to
d4d8ab5
Compare
|
I'm unsure why but CI says it doesn't compile under mingw. |
|
It looks like inline assembly is used and that probably isn't compatible with the MinGW toolchain. Perhaps document that it doesn't work on MinGW and we can configure in the code to ignore the feature on MinGW? |
arthurprs
force-pushed
the
cloudflare_zlib
branch
from
0e99fdf
to
ea91453
Compare
|
I modified the build to skip this feature on mingw and added a small note to the README. |
|
Thanks! |
|
@arthurprs It looks like there is a bunch of Is that intentional or an accidental omission? |
RReverser
added a commit
to RReverser/flate2-rs
that referenced
this pull request
Feb 27, 2020
|
@RReverser good eye. I overlooked those. |
|
Just made a PR above. |
alexcrichton
pushed a commit
that referenced
this pull request
Mar 2, 2020
* Expose zlib options on cloudflare-zlib See #228 (comment). * Add an any_zlib feature group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case that needed a faster gzip encoder. Is this something interesting to push upstream?
Some brief testing showed that compression at level 6 is twice as fast as the default backend.