-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Initial wasm support #165
Conversation
Very cool! I was waiting for the next PS: this makes it possible to read compressed pdf files in the browser using |
Thanks! I've pushed up a few commits to tweak things and build wasm on CI as well, all this should need now is a release upstream! |
Shouldn't the |
Sure yeah, makes sense to me! |
Merged eminence#1 ! |
@Frommi this came up today again in the context of wasm, and was curious, would you be up for publishing Frommi/miniz_oxide#35 to crates.io? |
(I'm guessing Frommi/miniz_oxide#37 might want to get in too then) |
I've merged the first PR, but last one may need more work. Only @Frommi has publish access on crates.io though. |
Oh oops I forgot the rebase would not flag this PR as merged, but this is merged now! |
work in progress. CC #161 and @wehlutyk and @Frommi
This takes the work that @wehlutyk did and builds on it by making miniz_oxide_c_api a mandatory requirement if using the wasm32 target. I don't think this can be merged until we get a new release of miniz_oxide, but I was able to test this change (along with the zip crate) to successfully unzip a .zip file in a browser.
I'm not sure if this is the right long-term approach, but I thought I'd open this PR to share with this success with the community.