Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial wasm support #165

Closed
wants to merge 5 commits into from
Closed

Conversation

eminence
Copy link
Contributor

@eminence eminence commented Aug 4, 2018

work in progress. CC #161 and @wehlutyk and @Frommi

This takes the work that @wehlutyk did and builds on it by making miniz_oxide_c_api a mandatory requirement if using the wasm32 target. I don't think this can be merged until we get a new release of miniz_oxide, but I was able to test this change (along with the zip crate) to successfully unzip a .zip file in a browser.

I'm not sure if this is the right long-term approach, but I thought I'd open this PR to share with this success with the community.

@wehlutyk
Copy link
Contributor

wehlutyk commented Aug 4, 2018

Very cool! I was waiting for the next miniz_oxide release to start this, which should be coming shortly.

PS: this makes it possible to read compressed pdf files in the browser using lopdf 😄

@alexcrichton
Copy link
Member

Thanks! I've pushed up a few commits to tweak things and build wasm on CI as well, all this should need now is a release upstream!

@wehlutyk
Copy link
Contributor

wehlutyk commented Aug 6, 2018

Shouldn't the cfg invocations all be aware that wasm32 can also be emscripten? See eminence#1

@alexcrichton
Copy link
Member

Sure yeah, makes sense to me!

@eminence
Copy link
Contributor Author

eminence commented Aug 6, 2018

Merged eminence#1 !

@alexcrichton
Copy link
Member

@Frommi this came up today again in the context of wasm, and was curious, would you be up for publishing Frommi/miniz_oxide#35 to crates.io?

@wehlutyk
Copy link
Contributor

wehlutyk commented Sep 28, 2018

(I'm guessing Frommi/miniz_oxide#37 might want to get in too then)

@oyvindln
Copy link
Contributor

I've merged the first PR, but last one may need more work.

Only @Frommi has publish access on crates.io though.

@alexcrichton
Copy link
Member

Oh oops I forgot the rebase would not flag this PR as merged, but this is merged now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants