Workaround to avoid having miniz_oxide_c_api export symbols that collide with miniz-sys #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide with miniz-sys For projects that have dependencies on both 0.2 and 1.0 versions of flate2
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects that have dependencies on both 0.2 and 1.0 versions of flate2 (particularly with zip-rs since it defaults to using the rust back-end). I didn't manage to trigger this myself, but someone else did: https://gitter.im/rust-lang/rust?at=5a57cc7183152df26d5d5cfc
This should hopefully avoid this for now. The c api wrapping was mainly used for ease of integration, ideally we would avoid it entirely for the rust backend, though that would be a much bigger change.