Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown menu display in top navbar #1717

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Apr 10, 2022

Fixes #1714.

We can't use overflow-y: hidden because it's then impossible (unless we use position: fixed) to display the dropdown menus. There is an ongoing discussion in the w3c about this here. But still far from done and even more far from implementation.

@GuillaumeGomez GuillaumeGomez changed the base branch from fix-top-navbar to master April 10, 2022 11:29
@GuillaumeGomez
Copy link
Member Author

Doesn't look very nice but at least not broken anymore:

Screenshot from 2022-04-10 13-26-32

@syphar syphar merged commit 15560cc into rust-lang:master Apr 10, 2022
@github-actions github-actions bot added the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Apr 10, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-top-navbar branch April 10, 2022 13:42
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The menu that should appear below the navigation bar is not displayed
2 participants