Add better error message for invalid crate names #7603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
changed the title
Turbo87
reviewed
Nov 29, 2023
| "detail": "\"🦀\" is an invalid dependency name (dependency names must start with a letter, contain only letters, numbers, hyphens, or underscores and have at most 64 characters)" | ||
| "detail": "invalid character `🦀` in crate name: `🦀`, the first character must be an ASCII character" |
There was a problem hiding this comment.
previously the error message was warning about a dependency name, but now it is only saying "crate name". maybe we need another error wrapper to give more context in this case?
There was a problem hiding this comment.
Oh, nice catch. I will update it.
There was a problem hiding this comment.
I submitted ccbcaee
I don't know if this is a good way to do it. Maybe it just introduces more confusion.
Do you have any suggestions to improve it? Or maybe we can keep it as the crate name. Because it literally is a crate name.
Turbo87
added
C-enhancement ✨
Signed-off-by: hi-rustin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #7379
The summary:
2. can only start with most letters or
_3. can only contain numbers,
-,_, or most letters.2. can only contain numbers, letters,
-,_2. can only contain numbers, letters,
-,_(Nothing changes)