Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-test-selectors: Disable obsolete/deprecated Component.reopen() call #3658

Merged
merged 1 commit into from
May 28, 2021
Merged

ember-test-selectors: Disable obsolete/deprecated Component.reopen() call #3658

merged 1 commit into from
May 28, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 27, 2021

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels May 27, 2021
pichfl
pichfl approved these changes May 28, 2021
View reviewed changes
Copy link

@pichfl pichfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@pichfl
Copy link

pichfl commented May 28, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 28, 2021

📌 Commit ed2a2e1 has been approved by pichfl

@bors
Copy link
Contributor

bors commented May 28, 2021

⌛ Testing commit ed2a2e1 with merge 9d79f7f...

@bors
Copy link
Contributor

bors commented May 28, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing 9d79f7f to master...

@bors bors merged commit 9d79f7f into rust-lang:master May 28, 2021
@Turbo87 Turbo87 deleted the test-selectors branch May 31, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichfl pichfl pichfl approved these changes

Assignees

@locks locks

@pichfl pichfl

Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Turbo87 @pichfl @bors @locks @rust-highfive