Remove version_authors and clean up old data

[Rustin170506]

close rust-lang/rust#83227

[rust-highfive]

r? @carols10cents

(rust-highfive has picked a reviewer for you, use r? to override)

[Rustin170506]

r? @pietroalbini

Can you help with the patch file issue? I'm actually tempted to delete the patch file as it doesn't seem to be helping us?

Because since we don't update it every time, it must be expired? Or do I still have a misunderstanding of how patch file works?

[pietroalbini]

Pushed a commit on your branch fixing the patch!

Because since we don't update it every time, it must be expired? Or do I still have a misunderstanding of how patch file works?

The patching tool is quite smart, and in most cases it will adapt to other schema.rs changes without the need to tweak the patch. Let's take for example the chunk of the patch that was giving you errors:

@@ -1016,6 +1031,7 @@
 joinable!(publish_limit_buckets -> users (user_id));
 joinable!(publish_rate_overrides -> users (user_id));
 joinable!(readme_renderings -> versions (version_id));
+joinable!(recent_crate_downloads -> crates (crate_id));
 joinable!(version_authors -> versions (version_id));
 joinable!(version_downloads -> versions (version_id));
 joinable!(version_owner_actions -> api_tokens (api_token_id));

The patching tool will apply this patch (adding the highlighted line) relative to the three lines above and below it. As long as those three lines above and below are not changed the tool will be able to apply the patch even if the rest of the file completely changes.

The problem here is that one of the lines below did change, as you removed the version_authors table. By doing so you removed the hit the patching tool needed to figure out where to apply the change.

To fix this issue, in my commit I had to remove the version_authors line from the patch. That was not enough though, as now there were only two lines below instead of three. After adding the following line in schema.rs the problem was fixed:

@@ -1016,6 +1031,7 @@
 joinable!(publish_limit_buckets -> users (user_id));
 joinable!(publish_rate_overrides -> users (user_id));
 joinable!(readme_renderings -> versions (version_id));
+joinable!(recent_crate_downloads -> crates (crate_id));
 joinable!(version_downloads -> versions (version_id));
 joinable!(version_owner_actions -> api_tokens (api_token_id));
 joinable!(version_owner_actions -> users (user_id));

If you have more questions around this just ask!

[pietroalbini]

Leaving the rest of the review back to Carol. r? @carols10cents

[Rustin170506]

@pietroalbini It's working well. Thanks!

[pietroalbini]

r? @pietroalbini

Thank you so much!
@bors r+

[bors]

📌 Commit 70c8e2a has been approved by pietroalbini

[bors]

⌛ Testing commit 70c8e2a with merge cd37d9d...

[bors]

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing cd37d9d to master...