Add support for Azure DevOps badge #1551
Conversation
robertohuertasm
changed the title
|
Hi, are there any updates here? Is there something I need to change to make it ready to be merged? Thanks! |
|
Is there anyone in particular that I must ping so I can get some feedback about whether this PR is going to be eventually merged or not? |
|
Hi, thank you for your patience. The team that maintains crates.io is all volunteer, and you'll notice that your pull request is not the only one we have to review. We will get to this as soon as we can. |
|
Hi @carols10cents, thanks for your feedback and apologies if I my messages felt a little bit rude but that wasn't at all my intention. I'm well aware of the effort that maintaining a project in a volunteer way requires and, of course, I already noticed that there are lots of PRs pending. The thing is that most of the other PRs have had some feedback or have been already merged, even when they were submitted after this one, and I wasn't sure if that was because you were not sure about supporting new badges, in which case, I was willing to close this PR and don't pay attention to it anymore. Again, thank you very much for your message! |
|
Hi, thank you again for your patience. I just took a look at the sample added to the mirage fixtures, which was very helpful so that I don't have to figure out how to set up Azure DevOps, thank you! However, when I run When I go to https://dev.azure.com/robertohuertasm/github-oss/_build?definitionId=2, click on the "..." to the right of the "edit" and "queue" buttons, then in the menu choose "status badge", the markdown recommended for this project is: The diff from this PR to what Azure recommends being: -https://dev.azure.com/robertohuertasm/github-oss/_apis/build/status/microserver
+https://dev.azure.com/robertohuertasm/github-oss/_apis/build/status/robertohuertasm.microserver?branchName=masterThe branch name doesn't appear to make a difference, but the second instance of When I visit your Azure DevOps page at https://dev.azure.com/robertohuertasm/github-oss/_build, I see that you have the pipelines "robertohuertasm.microserver", "robertohuertasm.mdlint", and "azure-rust": that is, some of them start with "robertohuertasm" and some of them don't. I don't know much about Azure Dev Ops, so I'm not sure if my guess is correct, but it looks like the fixture data should perhaps have pipeline set to "robertohuertasm.microserver" instead of "microserver"? When I make that change and reload http://localhost:4200/crates?page=2, the badge says "Azure pipelines: succeeded" instead of "set up" which seems better. Is that right? Or is there something about the parameters or image URL construction that isn't quite right? |
|
Hi @carols10cents, it seems that depending on how you setup the Azure pipeline the default name may include your username (at least if you're using a Github repo). Basically, you can setup your Azure pipeline by introducing a Anyway, the name can be changed at any time. I may have messed it up when I prepared this PR as it seems that I was using the proper url in my repo's badge. To make it easier I've changed the name of the pipeline so we don't have to submit any change here and now it works. I've just tested it again. Thanks @carols10cents for taking the time to review this! 😊 |
|
Thank you for bearing with me! The badge looks great now. I'll comment on the cargo PR when this change has been deployed! @bors: r+ |
|
📌 Commit 435f150 has been approved by |
…ents Add support for Azure DevOps badge I added a project of mine that is already using `Azure Devops` into `fixtures/crates.js`. Let me know if that's an inconvenience and I'll remove it. I just put it there to easily see that everything was working as expected. I also added some tests by following the existing code example. See also rust-lang/cargo#6264
|
💔 Test failed - checks-travis |
|
@carols10cents it seems that there were some errors after the automatic merging. I've fixed them and pushed again. It seems to be all ready for @bors: r+ |
|
@robertohuertasm: 🔑 Insufficient privileges: Not in reviewers |
|
Thank you for fixing! @bors: r+ |
|
📌 Commit 5eba143 has been approved by |
…ents Add support for Azure DevOps badge I added a project of mine that is already using `Azure Devops` into `fixtures/crates.js`. Let me know if that's an inconvenience and I'll remove it. I just put it there to easily see that everything was working as expected. I also added some tests by following the existing code example. See also rust-lang/cargo#6264
|
☀️ Test successful - checks-travis |
Add support for Azure DevOps Related to rust-lang/crates.io#1551 which is still pending to be merged.
I added a project of mine that is already using
Azure Devopsintofixtures/crates.js. Let me know if that's an inconvenience and I'll remove it. I just put it there to easily see that everything was working as expected.I also added some tests by following the existing code example.
See also rust-lang/cargo#6264