Updates #152

stefanpenner · 2015-05-07T05:09:36Z

This is slightly WIP. as the app doesn't have tests, I can't confirm super quickly, some of the differences appear to be different API data points. When I have a chance, I can compare the test UI against the production API.

update ember-cli + build tools to latest
update ember to latest
verify stuff isn't all broken
fix broken stuff

some future plans:

maybe backfill some smoke tests?
fix deprecations

alexcrichton · 2015-05-07T18:05:50Z

app/controllers/application.js

+    // don't use this from other controllers..
+    resetDropdownOption(controller, option) {
+        this.set(option, !this.get(option));
+        if (this.get(option)) {


How come this changed from controller to this? I'm not 100% sure why it was that way in the first place, but may be a spot of differences

alexcrichton · 2015-05-07T18:18:25Z

This looks awesome, thanks so much @stefanpenner! I mostly just have some stylistic nits and questions about the new syntax, but I'll also do some tests locally to make sure everything is still working as expected.

alexcrichton · 2015-05-07T18:31:50Z

Some things I've found:

Clicking the "Alphabetical" dropdown on /crates doesn't work (generates an exception)
There seem to be lots of deprecation warnings sprouted into the console when browsing around
The links on /install seem like they may not work

stefanpenner · 2015-05-07T19:07:36Z

There seem to be lots of deprecation warnings sprouted into the console when browsing around

ya, i would prefer to fix those after tests are added

…onfig)

…y disjoint command.

stefanpenner · 2015-05-07T20:31:01Z

Clicking the "Alphabetical" dropdown on /crates doesn't work (generates an exception)

this seems to work for me, can you elaborate ?

alexcrichton · 2015-05-07T20:49:11Z

Ah it looks like I mistook a deprecation warning as an exception. When I click the button, however, a drop down does not appear (nothing happens visually)

stefanpenner · 2015-05-07T20:54:14Z

a drop down does not appear (nothing happens visually)

seems to work for me.. hmm

* clear API * render will go away in 2.0 * more re-usable (less side-effects)

alexcrichton · 2015-05-07T21:05:50Z

Ah now it's working for me! Perhaps it was fixed in a commit I hadn't picked up yet?

stefanpenner · 2015-05-07T21:06:59Z

Ah now it's working for me! Perhaps it was fixed in a commit I hadn't picked up yet?

possible :)

* no more bind-attr

Turbo87 · 2015-10-31T01:26:07Z

@alexcrichton @stefanpenner what is the status of this PR? still any work going on here? I might be interested in picking it up again.

alexcrichton · 2015-11-02T19:04:35Z

Sorry I never got around to having time to test this out and make sure it's still all up to speed :(

…tle-5.1.0, r=locks Bump ember-page-title from 4.0.5 to 5.1.0 Bumps [ember-page-title](https://github.com/adopted-ember-addons/ember-page-title) from 4.0.5 to 5.1.0. <details> <summary>Release notes</summary> *Sourced from [ember-page-title's releases](https://github.com/adopted-ember-addons/ember-page-title/releases).* > ## 5.1.0 > Add a `front` argument to place the title at the front > > ## 5.0.2 > Update dependencies > > ## 5.0.1 > - Resolves Ember 3.6 deprecations > - Readme updated to reflect new location > - Docs site link updated > > ## 5.0.0 > 🚨 `prepend` is now `true` by default! > > ❤️ Thanks to [@ondrejsevcik](https://github.com/ondrejsevcik) for this change! For reasoning behind this, I'll quote them directly: > > > With a limited space to show in a page title, it's a best practice to put current page title first. Otherwise you end up with a title where you can't clearly see what page are you in. This is especially issue when you have nested pages with long titles. > </details> <details> <summary>Commits</summary> - [`b5338ef`](ember-cli/ember-page-title@b5338ef) Release 5.1.0 - [`f4e643f`](ember-cli/ember-page-title@f4e643f) feat: Make it possible to specify that a token should ALWAYS be in front ([#152](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/152)) - [`d32c4e9`](ember-cli/ember-page-title@d32c4e9) Release 5.0.2 - [`47f759a`](ember-cli/ember-page-title@47f759a) Merge pull request [#150](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/150) from efx/fix-remove-kruft - [`2c7fd67`](ember-cli/ember-page-title@2c7fd67) remove ember-cli-release configuration - [`b3a240c`](ember-cli/ember-page-title@b3a240c) Merge pull request [#149](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/149) from efx/fix-ember-try - [`0c62597`](ember-cli/ember-page-title@0c62597) fix ember try command - [`04f1e5a`](ember-cli/ember-page-title@04f1e5a) Merge pull request [#146](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/146) from efx/no-var - [`a9bd983`](ember-cli/ember-page-title@a9bd983) Merge branch 'latest' into no-var - [`5eb7775`](ember-cli/ember-page-title@5eb7775) Merge pull request [#147](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/147) from efx/update-ember-cli - Additional commits viewable in [compare view](ember-cli/ember-page-title@4.0.5...5.1.0) </details> <details> <summary>Maintainer changes</summary> This version was pushed to npm by [knownasilya](https://www.npmjs.com/~knownasilya), a new releaser for ember-page-title since your current version. </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-page-title&package-manager=npm_and_yarn&previous-version=4.0.5&new-version=5.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-page-title&package-manager=npm_and_yarn&previous-version=4.0.5&new-version=5.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details>

…1.1.0, r=locks Bump @ember/jquery from 0.6.1 to 1.1.0 Bumps [@ember/jquery](https://github.com/emberjs/ember-jquery) from 0.6.1 to 1.1.0. <details> <summary>Release notes</summary> *Sourced from [@ember/jquery's releases](https://github.com/emberjs/ember-jquery/releases).* > ## Release 1.1.0 > #### 🚀 Enhancement > * [#153](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/153) Add missing deprecation message for `this.$()` ([@Turbo87](https://github.com/Turbo87)) > > #### Committers: 3 > - Robert Jackson ([@rwjblue](https://github.com/rwjblue)) > - Tobias Bieniek ([@Turbo87](https://github.com/Turbo87)) > - [[@dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview) > > ## Release 1.0.0 > #### 💥 Breaking Change > * [#100](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/100) ember-cli-update to 3.10, drop node 6 ([@simonihmig](https://github.com/simonihmig)) > > #### 🚀 Enhancement > * [#148](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/148) Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration. ([@lupestro](https://github.com/lupestro)) > > #### 📝 Documentation > * [#145](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/145) Add directions to import and use jQuery ([@jrjohnson](https://github.com/jrjohnson)) > > #### Committers: 4 > - Jonathan Johnson ([@jrjohnson](https://github.com/jrjohnson)) > - Ralph Mack ([@lupestro](https://github.com/lupestro)) > - Simon Ihmig ([@simonihmig](https://github.com/simonihmig)) > - [[@dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview) </details> <details> <summary>Changelog</summary> *Sourced from [@ember/jquery's changelog](https://github.com/emberjs/ember-jquery/blob/master/CHANGELOG.md).* > ## v1.1.0 (2019-10-04) > > #### 🚀 Enhancement > * [#153](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/153) Add missing deprecation message for `this.$()` ([@Turbo87](https://github.com/Turbo87)) > > #### Committers: 3 > - Robert Jackson ([@rwjblue](https://github.com/rwjblue)) > - Tobias Bieniek ([@Turbo87](https://github.com/Turbo87)) > - [[@dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview) > > ## v1.0.0 (2019-10-02) > > #### 💥 Breaking Change > * [#100](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/100) ember-cli-update to 3.10, drop node 6 ([@simonihmig](https://github.com/simonihmig)) > > #### 🚀 Enhancement > * [#148](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/148) Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration. ([@lupestro](https://github.com/lupestro)) > > #### 📝 Documentation > * [#145](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/145) Add directions to import and use jQuery ([@jrjohnson](https://github.com/jrjohnson)) > > #### Committers: 4 > - Jonathan Johnson ([@jrjohnson](https://github.com/jrjohnson)) > - Ralph Mack ([@lupestro](https://github.com/lupestro)) > - Simon Ihmig ([@simonihmig](https://github.com/simonihmig)) > - [[@dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview) </details> <details> <summary>Commits</summary> - [`9112702`](emberjs/ember-jquery@9112702) Release 1.1.0 - [`c88dbf1`](emberjs/ember-jquery@c88dbf1) Add missing deprecation message for `this.$()` ([#153](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/153)) - [`dd96dd5`](emberjs/ember-jquery@dd96dd5) Remove `noDeprecations` tests - [`cade173`](emberjs/ember-jquery@cade173) Add missing deprecation message for `this.$()` - [`52886ad`](emberjs/ember-jquery@52886ad) Merge pull request [#152](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/152) from emberjs/dependabot/npm_and_yarn/ember-cli-htmlba... - [`7a533b7`](emberjs/ember-jquery@7a533b7) Bump ember-cli-htmlbars from 4.0.3 to 4.0.4 - [`32d79c3`](emberjs/ember-jquery@32d79c3) Re-roll yarn.lock to avoid issues with missing integrity in yarn… ([#151](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/151)) - [`4969158`](emberjs/ember-jquery@4969158) Re-roll yarn.lock to avoid issues with missing integrity in yarn 1.19.0 - [`0a6391d`](emberjs/ember-jquery@0a6391d) Bump eslint-plugin-node from 9.2.0 to 10.0.0 ([#133](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/133)) - [`07d66b4`](emberjs/ember-jquery@07d66b4) Merge pull request [#138](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/138) from emberjs/dependabot/npm_and_yarn/ember/optional-f... - Additional commits viewable in [compare view](emberjs/ember-jquery@v0.6.1...v1.1.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=@ember/jquery&package-manager=npm_and_yarn&previous-version=0.6.1&new-version=1.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=@ember/jquery&package-manager=npm_and_yarn&previous-version=0.6.1&new-version=1.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details>

update ember-app

7882a4e

alexcrichton reviewed May 7, 2015
View reviewed changes

cleanup + some es6ification

29c621c

stefanpenner force-pushed the updates branch from cf41483 to 29c621c Compare May 7, 2015 20:07

stefanpenner added 5 commits May 7, 2015 13:07

update editorconfig

ac43647

update some whitespace pre request (and now aligned with the .editorc…

1fbc979

…onfig)

restore traliing comma

e2514b8

fix indentation

ec9091b

make start:ui appear as a refinement to start, rather then an entirel…

3a80288

…y disjoint command.

stefanpenner added 3 commits May 7, 2015 13:58

fix /crates deprecations

5b57458

render “crates-list” -> {{crates-list component

1a572fe

* clear API * render will go away in 2.0 * more re-usable (less side-effects)

remove more deprecation from index

5656b85

stefanpenner force-pushed the updates branch from 439b808 to 5656b85 Compare May 7, 2015 20:58

stefanpenner added 2 commits May 7, 2015 14:07

fix more deprecations

6429889

* fixup more object proxy properties

a112e0e

* no more bind-attr

stefanpenner added 7 commits May 7, 2015 14:23

use new each form

f3aff4f

remove some bind-attr

8f4283f

render “crate-row” -> {{crate-row component

1183aad

remove more proxy usage

8ba8a7f

introduce link-to-dep

0e6779b

remove more bind-attr usage

828ea42

prefer new param form each

51ae402

Turbo87 mentioned this pull request Nov 3, 2015

Update Ember.js #208

Merged

alexcrichton merged commit 51ae402 into rust-lang:master Nov 9, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates #152

Updates #152

stefanpenner commented May 7, 2015

alexcrichton May 7, 2015

stefanpenner May 7, 2015

alexcrichton commented May 7, 2015

alexcrichton commented May 7, 2015

stefanpenner commented May 7, 2015

stefanpenner commented May 7, 2015

alexcrichton commented May 7, 2015

stefanpenner commented May 7, 2015

alexcrichton commented May 7, 2015

stefanpenner commented May 7, 2015

Turbo87 commented Oct 31, 2015

alexcrichton commented Nov 2, 2015

Updates #152

Updates #152

Conversation

stefanpenner commented May 7, 2015

alexcrichton May 7, 2015

Choose a reason for hiding this comment

stefanpenner May 7, 2015

Choose a reason for hiding this comment

alexcrichton commented May 7, 2015

alexcrichton commented May 7, 2015

stefanpenner commented May 7, 2015

stefanpenner commented May 7, 2015

alexcrichton commented May 7, 2015

stefanpenner commented May 7, 2015

alexcrichton commented May 7, 2015

stefanpenner commented May 7, 2015

Turbo87 commented Oct 31, 2015

alexcrichton commented Nov 2, 2015