Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Version::as_select() to allow skipping columns #10076

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Use Version::as_select() to allow skipping columns #10076

merged 2 commits into from
Nov 26, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 26, 2024 •
edited
Loading

This allows us to remove the unused num_no_build field of the struct, which means that we have to transfer less bytes from the database to the API server for the queries that result in one or many Version structs.

@Turbo87 Turbo87 assigned Turbo87 and unassigned Turbo87 Nov 26, 2024
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 26, 2024
@Turbo87 Turbo87 enabled auto-merge November 26, 2024 15:18
@Turbo87 Turbo87 merged commit cf4b176 into rust-lang:main Nov 26, 2024
8 checks passed
@Turbo87 Turbo87 deleted the optional-version-fields branch November 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Turbo87