Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider running generate-lockfiles in docker #101

Closed
brson opened this issue Jun 9, 2017 · 3 comments
Closed

Reconsider running generate-lockfiles in docker #101

brson opened this issue Jun 9, 2017 · 3 comments
Assignees
@pietroalbini
Labels
A-sandbox Area: build sandbox

Comments

@brson
Copy link
Contributor

brson commented Jun 9, 2017

Containerization seems to add significant time to prepare-ex, and there's no sandboxing requirement here.
@brson brson added the question label Jun 9, 2017
@aidanhs
Copy link
Member

aidanhs commented Sep 18, 2017

Or: start up a single container and do it all in there.

@aidanhs aidanhs mentioned this issue Sep 18, 2017
Open
9 tasks
@pietroalbini pietroalbini added A-sandbox Area: build sandbox and removed question labels Jul 1, 2018
@pietroalbini
Copy link
Member

This can also be done for cargo fetch.

@pietroalbini pietroalbini self-assigned this Oct 9, 2018
@pietroalbini
Copy link
Member

Implementing this myself in an unrelated refactoring.

@pietroalbini pietroalbini mentioned this issue Oct 10, 2018
Merged
bors added a commit that referenced this issue Oct 10, 2018
@bors
Auto merge of #341 - pietroalbini:refactor-runcommand, r=pietroalbini
b8d46c2 
Refactor RunCommand and add SandboxedRunCommand

Fixes #101
@bors bors closed this as completed in #341 Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietroalbini pietroalbini

Labels
A-sandbox Area: build sandbox
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @aidanhs @pietroalbini