-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 32-bit and 64-bit stderr/stdout files for ui tests #365
Labels
major-change
A proposal to make a major change to rustc
T-compiler
Add this label so rfcbot knows to poll the compiler team
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. |
@rustbot second |
hameerabbasi
added a commit
to hameerabbasi/rust
that referenced
this issue
Feb 6, 2021
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this issue
Feb 8, 2021
Add option to emit compiler stderr per bitwidth. See rust-lang/compiler-team#365 r? `@oli-obk`
This has been implemented in rust-lang/rust#81817 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major-change
A proposal to make a major change to rustc
T-compiler
Add this label so rfcbot knows to poll the compiler team
Proposal
Similarly to how mir-opt tests can generate an output file for each bit width, we would allow ui tests to do the same for its stderr/stdout dump files. This would be entirely opt-in, so all ui tests keep behaving as they do now, but if you add
// emit-stderr-for-each-bitwidth
to the test file, then you get a
.64bit.stderr
file instead of a plain.stderr
file. When you run the test on 32 bit you get a.32bit.stderr
file. Only the file for your platform is tested, so you need to rerun the test with--target i686-unknown-linux-gnu
on a 64 bit host in order to check the 32 bit test file.The reason I am suggesting this is that it's nearly impossible to specify a useful normalization regex for rust-lang/rust#76881 . The point is to test the output, ideally for each platform individually.
Mentors or Reviewers
Process
The main points of the Major Change Process is as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: