-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intern predicates, introduce forall/implies #285
Labels
major-change
A proposal to make a major change to rustc
major-change-accepted
A major change proposal that was accepted
Comments
@rustbot second |
FCP closed! See #72055 for initial implementation steps. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this issue
May 21, 2020
Intern predicates Implements the first step of rust-lang/compiler-team#285 Renames `ty::Predicate` to `ty::PredicateKind`, which is now interned. To ease the transition, `ty::Predicate` is now a struct containing a reference to `ty::PredicateKind`. r? @ghost
RalfJung
added a commit
to RalfJung/rust
that referenced
this issue
May 21, 2020
Intern predicates Implements the first step of rust-lang/compiler-team#285 Renames `ty::Predicate` to `ty::PredicateKind`, which is now interned. To ease the transition, `ty::Predicate` is now a struct containing a reference to `ty::PredicateKind`. r? @ghost
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jun 19, 2020
…komatsakis Cache flags and escaping vars for predicates With predicates becoming interned (rust-lang/compiler-team#285) this is now possible and could be a perf win. It would become an even larger win once we have recursive predicates. cc @lcnr @nikomatsakis r? @ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 21, 2020
…matsakis Cache flags and escaping vars for predicates With predicates becoming interned (rust-lang/compiler-team#285) this is now possible and could be a perf win. It would become an even larger win once we have recursive predicates. cc @lcnr @nikomatsakis r? @ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 27, 2020
… r=nikomatsakis convert higher ranked `Predicate`s to `PredicateKind::ForAll` implements step 2 of rust-lang/compiler-team#285 r? @nikomatsakis
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major-change
A proposal to make a major change to rustc
major-change-accepted
A major change proposal that was accepted
TL;DR
Refactor
ty::Predicate
to better align with how chalk handles things and to enable what we need for GATs. Highlights:Goals:
forall<T> { if (T: Debug) { Vec<T>: Debug } }
.Predicate::Trait
would be an ordinaryTraitRef
)Predicate<'tcx>
to an interned reference (&'tcx PredicateKind<'tcx>
) to enable recursionSteps
Predicate
toPredicateKind
, introducetype Predicate = PredicateKind
Predicate
and altertype Predicate<'tcx>
to&'tcx PredicateKind<'tcx>
forall
predicate goals and integrate into the fulfillment contextParamEnv
with new predicatesMentors or Reviewers
nikomatsakis will mentor
The text was updated successfully, but these errors were encountered: