Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integer to f16 conversions #729

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add integer to f16 conversions #729

wants to merge 2 commits into from

Commits on Nov 5, 2024

  1. Disable f16 on platforms that have recursion problems 

    CI in [1] seems to indicate that there are cases where the `f16`
infinite recursion bug ([2], [3]) can make its way into what gets called
during tests, even though this doesn't seem to be the usual case. In
order to make sure that we avoid these completely, just unset
`f16_enabled` on any platforms that have the recursion problem.

This also refactors the `match` statement to be more in line with
`library/std/build.rs`.

[1]: rust-lang#729
[2]: llvm/llvm-project#97981
[3]: rust-lang#651
    @tgross35
    tgross35 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    077f018 View commit details
    Browse the repository at this point in the history

  2. Add integer to f16 conversions 

    These are not present in LLVM's `compiler-rt` but LLVM does emit them in
some cases [1].

[1]: rust-lang/rust#132614 (comment)
    @tgross35
    tgross35 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f6a5429 View commit details
    Browse the repository at this point in the history