Wrap all intrinsics in the intrinsics! macro #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that each intrinsic ends up in a separate module, which in turn (because rustc treats compiler_builtins specially) will result in each intrinsic ending up in its own object file. This allows the linker to only pick up object files for intrinsics that are missing and avoids duplicate symbol definition errors.
Closed
|
@Amanieu |
|
Yes, I'm working on it. |
This was referenced Feb 6, 2022
Amanieu
added a commit
to Amanieu/rustc-builtins
that referenced
this pull request
Feb 9, 2022
Accidentally introduced in rust-lang#452
Amanieu
added a commit
to Amanieu/rustc-builtins
that referenced
this pull request
Feb 9, 2022
Accidentally introduced in rust-lang#452
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2022
…ark-Simulacrum Bump compiler-builtins to 0.1.69 This includes rust-lang/compiler-builtins#452 which should fix some issues with duplicate symbol defintions of some intrinsics.
vladimir-ea
pushed a commit
to vladimir-ea/compiler-builtins
that referenced
this pull request
Mar 8, 2022
Accidentally introduced in rust-lang#452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that each intrinsic ends up in a separate module, which in turn (because rustc treats compiler_builtins specially) will result in each intrinsic ending up in its own object file. This allows the linker to only pick up object files for intrinsics that are missing and avoids duplicate symbol definition errors.