Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.53.0 and re-enable macos MSRV check #894

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Bump MSRV to 1.53.0 and re-enable macos MSRV check #894

merged 2 commits into from
Nov 4, 2023

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Nov 4, 2023

To solve the issue mentioned #889 (comment)

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Nov 4, 2023

Oops, it looks like 1.53 still has problem with linking on latest macos.
Will revert that change.

Since 1.53 still can't link on latest macos

Signed-off-by: Jiahao XU <[email protected]>
@thomcc
Copy link
Member

thomcc commented Nov 4, 2023

Hm, do you know which version fixes it?

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Nov 4, 2023

Hm, do you know which version fixes it?

Probably 1.56 or 1.58, had the same issue in https://github.com/cargo-bins/jobslot , however even 1.56 might be too new for some users (@dot-asm ).

Given that there's only one line of cfg!(target_os = "macos") which does not conditionally pull in new code but instead evalutes to a boolean, I think it's fine not checking on macos.

@NobodyXu NobodyXu merged commit bd25128 into rust-lang:main Nov 4, 2023
16 checks passed
@NobodyXu NobodyXu deleted the bump-msrv branch November 4, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants