-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only pass .asm
files to masm
#755
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Effectively restoring the previous behaviour to prevent unintentional breakages looks good to me. I only have a few minor nits.
328c2dc
to
78974fc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fwiw this is more-so caused by the |
Yeah, the point is more: you should actually be allowed to compile that file with clang-cl, even if the logic you used to decide whether or not to include it was buggy. |
@thomcc is this still on track to be released? We're currently failing to compile https://github.com/sonos/tract/blob/main/linalg/build.rs |
Ah, thanks for the reminder, I'll do a release as soon as possible. |
@MarijnS95 Sorry for the delay, it's in https://github.com/rust-lang/cc-rs/releases/tag/1.0.78. |
A wrinkle here is that |
Oh hm. Maybe! We probably should have ways to override any and all heuristics in any case. |
This changes the handling of assembly on MSVC targets so that only
.asm
files are passed to masm. This is more in line with how things were handled in cc <1.0.77, and would have avoided #754.