Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add -fPIC by default on UEFI targets #1263

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Nov 2, 2024

This fixes a regression caused by 290a629.

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM, cc @madsmtm can you double-check please?

This fixes a regression caused by 290a629.
@nicholasbishop
Copy link
Contributor Author

Pushed a fix to my commit message, the regression was in 290a629 rather than 9c663ca.

Copy link
Collaborator

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's my bad for sure, sorry!

@NobodyXu NobodyXu merged commit ecea93e into rust-lang:main Nov 4, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants