Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC_SHELL_ESCAPED_FLAGS: improve docs #1183

Merged
merged 1 commit into from
Aug 15, 2024
Merged

CC_SHELL_ESCAPED_FLAGS: improve docs #1183

merged 1 commit into from
Aug 15, 2024

Conversation

xbjfk
Copy link
Contributor

@xbjfk xbjfk commented Aug 15, 2024

Hello, after a little thinking I realise I wasn't too happy with the docs I wrote and think they are verbose - and decided to make it more concise and in plain English:

  • CC_SHELL_ESCAPED_FLAGS - if set, *FLAGS will be parsed as if they were shell arguments (similar to make and cmake) rather than splitting them on each space. For example, with CFLAGS='a "b c"', the compiler will be invoked with 2 arguments - a and b c - rather than 3: a, "b and c".

Thanks :)

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the new doc is simpler to read.

@NobodyXu NobodyXu merged commit dcbe0f1 into rust-lang:main Aug 15, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants