Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass -fPIC by default on wasm #1240

Closed
bjorn3 opened this issue Oct 7, 2024 · 1 comment · Fixed by #1245
Closed

Don't pass -fPIC by default on wasm #1240

bjorn3 opened this issue Oct 7, 2024 · 1 comment · Fixed by #1245

Comments

@bjorn3
Copy link
Member

bjorn3 commented Oct 7, 2024 •
edited
Loading

Rustc by default doesn't generate pic code on wasm targets by default and it seems that mixing pic and no-pic code on wasm results in broken wasm modules in some cases: WebAssembly/wasi-sdk#492
@NobodyXu
Copy link
Collaborator

NobodyXu commented Oct 9, 2024

Thanks for reporting!

I can work on this but is a bit busy, if you already have a PR working I'm happy to review it.

NobodyXu added a commit that referenced this issue Oct 11, 2024
@NobodyXu
Don't pass -fPIC by default on wasm
c1f07fc 
Fix #1240
@NobodyXu NobodyXu mentioned this issue Oct 11, 2024
Merged
madsmtm added a commit to madsmtm/cc-rs that referenced this issue Nov 10, 2024
@madsmtm
Properly disable PIC on WASM targets
30a9a3a 
CC rust-lang#1240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pass -fPIC by default on wasm rust-lang/cc-rs
2 participants
@bjorn3 @NobodyXu