Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert curl-sys update. #9920

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 18, 2021

This reverts curl-sys to the previously working version, with the intent to get nightly working again until 7.79.1 is published next week.

Fixes #9919

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 18, 2021

📌 Commit 637ee66 has been approved by alexcrichton

@alexcrichton alexcrichton reopened this Sep 18, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 18, 2021

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 18, 2021

📌 Commit 637ee66 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 18, 2021

⌛ Testing commit 637ee66 with merge dec716eda96d269beab393f2fbd6fc13e21ce0bf...

@bors
Copy link
Contributor

bors commented Sep 18, 2021

⌛ Testing commit 637ee66 with merge ef5d1d2...

bors added a commit that referenced this pull request Sep 18, 2021
Temporarily revert curl-sys update.

This reverts curl-sys to the previously working version, with the intent to get nightly working again until 7.79.1 is published next week.

Fixes #9919
@bors
Copy link
Contributor

bors commented Sep 18, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Sep 18, 2021

@alexcrichton I'm pretty sure you'll need to manually merge this, sorry I should have mentioned that.

@alexcrichton alexcrichton merged commit 9a28ac8 into rust-lang:master Sep 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2021
Update cargo

1 commits in 33ee5f82edb50af87b952c5b28de0f5fb41ebf18..9a28ac83c9eb73e42ffafac552c0a55f00dbf40c
2021-09-17 13:51:54 +0000 to 2021-09-18 15:42:28 -0500
- Temporarily revert curl-sys update. (rust-lang/cargo#9920)
@@ -26,7 +26,7 @@ cargo-util = { path = "crates/cargo-util", version = "0.1.1" }
crates-io = { path = "crates/crates-io", version = "0.33.0" }
crossbeam-utils = "0.8"
curl = { version = "0.4.38", features = ["http2"] }
curl-sys = "0.4.47"
curl-sys = "0.4.45"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Cargo defaults to a caret dependency, will this continue to pull the broken version?

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

Or will the broken version be yanked, so this is okay?

(You're probably on top of this; just want to make sure 😅)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually downgraded the lockfile in rust-lang/rust (see rust-lang/rust#89079). Will update to 0.4.48 when a new version of libcurl is published next week.

@ehuss ehuss added this to the 1.57.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Spurious network error" when building on GitHub Actions with Nightly 2021-09-18
5 participants