-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily revert curl-sys update. #9920
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 637ee66 has been approved by |
@bors: r+ |
💡 This pull request was already approved, no need to approve it again. |
📌 Commit 637ee66 has been approved by |
⌛ Testing commit 637ee66 with merge dec716eda96d269beab393f2fbd6fc13e21ce0bf... |
Temporarily revert curl-sys update. This reverts curl-sys to the previously working version, with the intent to get nightly working again until 7.79.1 is published next week. Fixes #9919
💔 Test failed - checks-actions |
@alexcrichton I'm pretty sure you'll need to manually merge this, sorry I should have mentioned that. |
Update cargo 1 commits in 33ee5f82edb50af87b952c5b28de0f5fb41ebf18..9a28ac83c9eb73e42ffafac552c0a55f00dbf40c 2021-09-17 13:51:54 +0000 to 2021-09-18 15:42:28 -0500 - Temporarily revert curl-sys update. (rust-lang/cargo#9920)
@@ -26,7 +26,7 @@ cargo-util = { path = "crates/cargo-util", version = "0.1.1" } | |||
crates-io = { path = "crates/crates-io", version = "0.33.0" } | |||
crossbeam-utils = "0.8" | |||
curl = { version = "0.4.38", features = ["http2"] } | |||
curl-sys = "0.4.47" | |||
curl-sys = "0.4.45" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Cargo defaults to a caret dependency, will this continue to pull the broken version?
Or will the broken version be yanked, so this is okay?
(You're probably on top of this; just want to make sure 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually downgraded the lockfile in rust-lang/rust (see rust-lang/rust#89079). Will update to 0.4.48 when a new version of libcurl is published next week.
This reverts curl-sys to the previously working version, with the intent to get nightly working again until 7.79.1 is published next week.
Fixes #9919