Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when with resolver = "1" non-virtual package was allowing unknown features #9437

Merged
merged 12 commits into from
May 24, 2021
+97 −40
Merged

Fix bug when with resolver = "1" non-virtual package was allowing unknown features #9437

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e80b5c2
Add failing test
In-line Apr 30, 2021
f2b5271
Cargo fmt
In-line Apr 30, 2021
f461453
Fix bug when with resolver = "1" non-virtual package was allowing unk…
In-line May 3, 2021
8c4b0a8
Remove trailing space
In-line May 3, 2021
2115265
Move check to the end of function, rework error message
In-line May 6, 2021
ba8cfe1
Refactor checking loop to iterator.collect()
In-line May 6, 2021
503a867
Another way to fix
In-line May 13, 2021
ca0cce7
Revert unnecessary changes
In-line May 20, 2021
2762dcd
Revert fmt
In-line May 20, 2021
766c3bb
Merge branch 'master' of github.com:rust-lang/cargo into unknown-feat…
In-line May 20, 2021
1839ded
Cargo fmt
In-line May 20, 2021
61b762b
Remove unneeded masquerade_as_nightly_cargo.
ehuss May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove trailing space
@In-line
In-line authored May 3, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 8c4b0a8559a17ae31bce063960fab3a22ce7362c
2 changes: 1 addition & 1 deletion tests/testsuite/package_features.rs
View file
Original file line number Diff line number Diff line change
@@ -215,7 +215,7 @@ fn other_member_from_current() {
name = "bar"
version = "0.1.0"

[features]
[features]
f1 = []
f2 = []
f3 = []