fix: remove unnecessary lockfile header comparison #8622
Closed
+16
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8610
What
#6548 introduced generated headers, which makes
fn are_equal_lockfiles()
always return false if a lockfile contains the header. This PR let the equality check 1) skip lines of header and 2) remove unnecessarystr::to_string
andString::replace
allocations by using iterators to solve the minor regression bug.